Skip to content

Conversation

@3pings
Copy link
Contributor

@3pings 3pings commented Apr 18, 2025

Added support for Piraeus CSI and addon layers as 2 different packs

@3pings 3pings requested review from kreeuwijk and vishwanaths April 18, 2025 17:03
@kreeuwijk
Copy link
Contributor

@3pings the add-on variant is already part of the repo, we only need to add the csi variant

@3pings
Copy link
Contributor Author

3pings commented Apr 21, 2025

@kreeuwijk it is all about the naming. The name of the existing addon does not conform to what we have been using for other csi-addons or pack naming. It conflicts with some other automation

Copy link
Contributor

@kreeuwijk kreeuwijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishwanaths vishwanaths merged commit 0f0abb8 into main Apr 29, 2025
1 of 2 checks passed
@vishwanaths vishwanaths deleted the piraeus branch April 29, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants